Skip to content

Find paths ignored in .gitignore #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2020
Merged

Find paths ignored in .gitignore #1063

merged 3 commits into from
Sep 29, 2020

Conversation

saroad2
Copy link
Contributor

@saroad2 saroad2 commented Sep 28, 2020

Using git check-ignore in order to find whether paths are ignored or not in .gitignore

Byron
Byron requested changes Sep 29, 2020
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for you contribution!

The merge is just two minor changes away, with the option for a bigger change for correctness. The latter won't block a merge though in case there is no time for that.

Byron
Byron requested changes Sep 29, 2020
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! I think that leaves just one tiny thing before it can be merged.
Thanks for bearing with me.

@Byron Byron added this to the v3.1.9 - Bugfixes milestone Sep 29, 2020
@Byron Byron merged commit 60acfa5 into gitpython-developers:master Sep 29, 2020
@saroad2 saroad2 deleted the find_ignored_path branch September 29, 2020 06:24
@Byron
Copy link
Member

Byron commented Sep 29, 2020

Great, thanks again!

@saroad2
Copy link
Contributor Author

saroad2 commented Sep 29, 2020

Thanks a lot for the merge!

When are you planning on releasing a new version to PyPi? I would like to use this new ability in one of my projects.

@Byron
Copy link
Member

Byron commented Oct 1, 2020

Version 3.1.9 was just published to PyPi. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron requested changes

Assignees
No one assigned
Labels
None yet
Milestone
v3.1.9 - Bugfixes
Development

Successfully merging this pull request may close these issues.
2 participants
@saroad2 @Byron